fix(workflows): re-evaluate maintainer gate on reviews, require head-SHA approval#288
Merged
Merged
Conversation
…SHA approval Ports agentrust-io/.github#8. Refs agentrust-io/.github#9. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ports the maintainer-gate fix from agentrust-io/.github#8 into this repo's copy of
require-maintainer-approval.yml. Refs agentrust-io/.github#9.This repo's copy is an older variant of the gate (job
gate, in-script author-association skip, github-script v7 pin), so the fix was ported into that structure rather than overwriting with the canonical file:pull_request_review: [submitted, dismissed]trigger so an approval re-evaluates the gate without waiting for a push.pull_request_reviewdoes not support abranchesfilter, so the base-branch check moved to a job-levelif(github.event.pull_request.base.ref == 'main').commit_idequal to the PR head SHA fetched at evaluation time.listReviewsnow usesgithub.paginate(the unpaginated call caps at 30 reviews).Kept as-is from this repo's variant: workflow/job naming,
statuses: writepermission, github-script v7.0.1 pin, in-script MEMBER/OWNER skip.Validated with
yaml.safe_load.Note: This PR is itself blocked by the broken gate it fixes. Approve then re-run the gate workflow manually, or admin-merge.
Generated with Claude Code