fix(canonicalize): use RFC 8785 JCS from agent-manifest SDK#31
Merged
Conversation
Replace the local json.dumps canonicalization in validate_artifacts.py with agent_manifest.canonicalize(), which implements RFC 8785 JCS. Add agent-manifest SDK as a direct dependency and update the cmcp-runtime pin to include the Agent Manifest session binding. Signed-off-by: Imran Siddique <imran.siddique@opaque.co> Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
json.dumps(sort_keys=True, ensure_ascii=True)invalidate_artifacts.pywithagent_manifest.canonicalize(), the canonical RFC 8785 JCS implementation from the Agent Manifest SDKagent-manifestas a direct dependency torequirements.txtcmcp-runtimepin to include the Agent Manifest session binding (PR #323)The existing fixtures are unaffected: the example contains ASCII-only content with no floats, so both implementations produce identical bytes.
Test plan
validate_artifacts.pyruns cleanly end-to-end with the updated dependenciesSigned-off-by: Imran Siddique imran.siddique@opaque.co