feat: v0.2 -- accept DID URIs in TR-ENV-003 subject check#18
Merged
Conversation
Updates tr_env.py, test_level0.py, and test_tr_env.py to accept both spiffe:// and did: subject URIs. Adds did:key and did:mesh passing tests. Aligns with agentrust-io/trace-spec#35 and trace-spec v0.2.0. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…ests - tr_sig.py: verify Ed25519 embedded signatures in plain trace records (sign_record() output) - loader.py: remove "signature" from partial envelope markers so signed plain records load - test_tr_sig.py: add test_plain_trace_embedded_ed25519_signature_passes and tamper test - README.md: v0.2 badge, "What changed in v0.2" section - pyproject.toml: bump version to 0.2.0 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
imran-siddique
force-pushed
the
feat/v0.2-did-subject-support
branch
from
90378c0 to
e4d6ddf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updates the conformance test suite to accept both
spiffe://anddid:subject URIs, aligned with trace-spec v0.2.0.What changed:
src/trace_tests/modules/tr_env.py: TR-ENV-003 check acceptsspiffe://ordid:, fail message updatedtests/test_level0.py:SPIFFE_RE→SUBJECT_RE, test renamedtest_subject_is_valid_workload_identity_uritests/unit/test_tr_env.py: addedtest_did_subject_passesandtest_did_mesh_subject_passes; renamedtest_non_spiffe_subject_fails→test_non_spiffe_non_did_subject_failsTest plan
pytest tests/passesdid:key:subject passes TR-ENV-003did:mesh:subject passes TR-ENV-003https://subject still fails TR-ENV-003References
🤖 Generated with Claude Code