Skip to content

fix(controller): sync Human worker allowlist#972

Open
RerankerGuo wants to merge 2 commits into
agentscope-ai:mainfrom
RerankerGuo:fix/issue-954-human-worker-allowlist
Open

fix(controller): sync Human worker allowlist#972
RerankerGuo wants to merge 2 commits into
agentscope-ai:mainfrom
RerankerGuo:fix/issue-954-human-worker-allowlist

Conversation

@RerankerGuo

Copy link
Copy Markdown

Summary

  • sync Human spec.accessibleWorkers into target Worker channelPolicy.groupAllowExtra so room access also grants runtime message permission
  • mark controller-managed allowlist entries with a Worker annotation so revokes/deletes only remove entries created by Human reconciliation
  • add HumanReconciler tests for add, revoke, and preserving manual allowlist entries

Fixes #954.

Tests

  • git diff --check
  • rg -n "<<<<<<<|=======|>>>>>>>" changelog/current.md hiclaw-controller/internal/controller

Not run: go test ./internal/controller because this environment does not have the Go toolchain (go: command not found).

@github-actions

github-actions Bot commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

❌ Integration Tests Failed (llm-interaction / mgr=copaw / wk=hermes)

Commit: eb2b02b
Workflow run: #1412

Test Results
No test output captured.
Debug Log (tail)
No debug logs available.

📦 Download full debug logs & test artifacts

@github-actions

github-actions Bot commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

📊 CI Metrics Report

Summary

Metric Current Baseline Change
LLM Calls 103 81 +22 ↑ +27.2%
Input Tokens 3264305 2803871 +460434 ↑ +16.4%
Output Tokens 24374 16791 +7583 ↑ +45.2%
Total Tokens 3288679 2820662 +468017 ↑ +16.6%

By Role

Role Metric Current Baseline Change
🧠 Manager LLM Calls 84 68 +16 ↑ +23.5%
Input Tokens 2857828 2502214 +355614 ↑ +14.2%
Output Tokens 19008 13725 +5283 ↑ +38.5%
Total Tokens 2876836 2515939 +360897 ↑ +14.3%
🔧 Workers LLM Calls 19 13 +6 ↑ +46.2%
Input Tokens 406477 301657 +104820 ↑ +34.7%
Output Tokens 5366 3066 +2300 ↑ +75.0%
Total Tokens 411843 304723 +107120 ↑ +35.2%

Per-Test Breakdown

Test Mgr Calls Wkr Calls Δ Calls Mgr In Wkr In Mgr Out Wkr Out Δ Tokens Trend
02-create-worker 4 0 -8 ↓ -66.7% 108385 0 425 0 -249812 ↓ -69.7% ✅ improved
03-assign-task 8 8 +1 ↑ +6.7% 197418 183988 1305 1152 -89793 ↓ -19.0% ⚠️ regressed
04-human-intervene 18 0 +5 ↑ +38.5% 467004 0 2884 0 +36890 ↑ +8.5% ⚠️ regressed
05-heartbeat 6 0 -1 ↓ -14.3% 169740 0 1220 0 -104292 ↓ -37.9% ✅ improved
06-multi-worker 48 11 +25 ↑ +73.5% 1915281 222489 13174 4214 +875024 ↑ +68.4% ⚠️ regressed

Trends

2 test(s) improved (fewer LLM calls)
⚠️ 3 test(s) regressed (more LLM calls)


Generated by HiClaw CI on 2026-07-03 03:18:03 UTC


📦 Download debug logs & test artifacts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

您目前没有访问此智能体的权限,需要审批。 || You currently do not have permission to access this agent and need approval.

1 participant