Skip to content

fix(copaw): guard managed skill cleanup#982

Open
RerankerGuo wants to merge 1 commit into
agentscope-ai:mainfrom
RerankerGuo:fix/issue-626-copaw-delete-guards
Open

fix(copaw): guard managed skill cleanup#982
RerankerGuo wants to merge 1 commit into
agentscope-ai:mainfrom
RerankerGuo:fix/issue-626-copaw-delete-guards

Conversation

@RerankerGuo

Copy link
Copy Markdown

Summary

  • add a managed-directory removal guard for CoPaw skill cleanup paths
  • refuse recursive deletion unless the target is a non-symlink direct child of the expected managed directory
  • cover the sync cleanup guard with unit tests

Addresses the recursive-delete hardening items in #626.

Verification

  • python3 -m py_compile copaw/src/copaw_worker/sync.py copaw/src/copaw_worker/worker.py copaw/tests/test_sync.py
  • PYTHONPATH=/tmp/agentteams-pytest:copaw/src python3 -m pytest copaw/tests/test_sync.py (15 passed)
  • git diff --check

@github-actions

github-actions Bot commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

📊 CI Metrics Report

Summary

Metric Current Baseline Change
LLM Calls 114 81 +33 ↑ +40.7%
Input Tokens 3194117 2803871 +390246 ↑ +13.9%
Output Tokens 36031 16791 +19240 ↑ +114.6%
Total Tokens 3230148 2820662 +409486 ↑ +14.5%

By Role

Role Metric Current Baseline Change
🧠 Manager LLM Calls 58 68 -10 ↓ -14.7%
Input Tokens 1756408 2502214 -745806 ↓ -29.8%
Output Tokens 11577 13725 -2148 ↓ -15.7%
Total Tokens 1767985 2515939 -747954 ↓ -29.7%
🔧 Workers LLM Calls 56 13 +43 ↑ +330.8%
Input Tokens 1437709 301657 +1136052 ↑ +376.6%
Output Tokens 24454 3066 +21388 ↑ +697.6%
Total Tokens 1462163 304723 +1157440 ↑ +379.8%

Per-Test Breakdown

Test Mgr Calls Wkr Calls Δ Calls Mgr In Wkr In Mgr Out Wkr Out Δ Tokens Trend
02-create-worker 4 0 -8 ↓ -66.7% 109228 0 410 0 -248984 ↓ -69.4% ✅ improved
03-assign-task 8 5 -2 ↓ -13.3% 198865 111217 1445 748 -161381 ↓ -34.1% ✅ improved
04-human-intervene 17 15 +19 ↑ +146.2% 390005 303000 3047 1454 +264508 ↑ +61.1% ⚠️ regressed
05-heartbeat 4 5 +2 ↑ +28.6% 96052 131685 1231 891 -45393 ↓ -16.5% ⚠️ regressed
06-multi-worker 25 31 +22 ↑ +64.7% 962258 891807 5444 21361 +600736 ↑ +46.9% ⚠️ regressed

Trends

2 test(s) improved (fewer LLM calls)
⚠️ 3 test(s) regressed (more LLM calls)


Generated by HiClaw CI on 2026-07-02 22:05:08 UTC


📦 Download debug logs & test artifacts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant