Update algorithm List in README#498
Conversation
Summary of ChangesHello @pan-x-c, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request primarily updates the project's documentation to reflect recent additions to its algorithm offerings. It integrates the SFT and DPO algorithms into both English and Chinese versions of the README and Sphinx documentation, ensuring that users have up-to-date information on available functionalities. Additionally, it rectifies an outdated example link for the 'On-Policy Distillation' algorithm and adjusts the project's core dependencies by promoting Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
The pull request updates the algorithm list in the README.md, README_zh.md, and corresponding Sphinx documentation files (docs/sphinx_doc/source/main.md, docs/sphinx_doc/source_zh/main.md). It adds entries for SFT and DPO algorithms, and updates the example path for On-Policy Distillation. Additionally, the pyproject.toml file has been modified to move matplotlib from development dependencies to core dependencies, indicating its broader usage within the project. The changes are well-formatted and maintain consistency across the documentation files, including a consistent translation update from "例子" to "示例" in the Chinese documentation.
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request updates the documentation by adding SFT and DPO to the algorithm lists and including a new guide on runtime monitoring for workflow developers. The changes are mostly good, but I've found a few issues: several markdown files have a broken link due to a typo in the link syntax, there's a typo in the new monitoring guide, and a dependency change in pyproject.toml that needs clarification. Overall, these are straightforward documentation and dependency updates.
Description
Checklist
Please check the following items before code is ready to be reviewed.