Open
Conversation
Collaborator
Author
|
/unittest-diff |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request introduces several improvements and new features to the Trinity explorer's dynamic timeout mechanism and task result handling pipeline. The main changes include adding a warmup step threshold for dynamic timeout activation, implementing staged task payload management in the experience pipeline, and updating the explorer and scheduler to support event-driven task completion and payload cleanup. The documentation and tests have also been updated accordingly.
Dynamic timeout improvements:
warmup_min_stepsparameter to the dynamic timeout configuration, ensuring that dynamic timeout is only enabled after a minimum number of fully observed steps. This prevents premature timeout adjustments based on insufficient data. [1] [2] [3] [4] [5]warmup_min_stepsoption and clarify the dynamic timeout mechanism. [1] [2]Experience pipeline enhancements:
experience_pipeline.pyto stage, finalize, drain, and abort task payloads for each batch, enabling more flexible and reliable management of experience data before processing. [1] [2]Explorer and scheduler integration:
ExploreStepBufferdataclass. This allows for more precise control over when and how task results are processed and finalized. [1] [2] [3] [4] [5] [6]Testing:
These changes collectively improve the reliability, flexibility, and transparency of the explorer's task scheduling and experience data processing pipeline.
Checklist
Please check the following items before code is ready to be reviewed.