fix(rag): Exclude jackson3 from elasticsearch-java9

[guanxuc]

AgentScope-Java Version

1.0.9

Description

Fixes: #728

Note

Exclude jackson3 to resolve the dependency conflict, but when upgrade to jackson3, we need to update the code.

Checklist

Please check the following items before code is ready to be reviewed.

• Code has been formatted with mvn spotless:apply
• All tests are passing (mvn test)
• Javadoc comments are complete and follow project conventions
• Related documentation has been updated (e.g. links, examples, etc.)
• Code is ready for review

[gemini-code-assist]

Summary of Changes

Hello @guanxuc, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a critical dependency conflict within the agentscope-extensions-rag-simple module. By explicitly excluding specific Jackson 3 components from the elasticsearch-java dependency, it ensures application stability and prevents runtime issues caused by incompatible library versions. This change is a targeted fix to maintain compatibility without a full Jackson version upgrade.

Highlights

• Dependency Conflict Resolution: The pull request resolves a dependency conflict by explicitly excluding jackson-databind and jackson-core (Jackson 3) from the elasticsearch-java dependency within the agentscope-extensions-rag-simple module's pom.xml.
• Future Upgrade Note: The author notes that while this exclusion resolves the immediate conflict, a full upgrade to Jackson 3 would necessitate corresponding code updates.

Changelog

• agentscope-extensions/agentscope-extensions-rag-simple/pom.xml
  • Added <exclusions> for tools.jackson.core:jackson-databind and tools.jackson.core:jackson-core under the co.elastic.clients:elasticsearch-java dependency.

Activity

• The pull request was opened by guanxuc to fix issue [Bug]:agentscope-java: 1.0.8，QuickStart示例报错 #728.
• The author has completed the pre-review checklist, confirming code formatting, passing tests, complete Javadoc, and updated documentation.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request addresses a dependency conflict by excluding Jackson 3 artifacts, which are transitively introduced by elasticsearch-java. The fix is correct, but I've suggested a more robust way to exclude all potential Jackson 3 artifacts to prevent similar issues in the future.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!