Define ag-harness design#96
Conversation
a6fa521 to
d3396ed
Compare
dc833c5 to
aa35d1a
Compare
|
@codex review |
|
Codex Review: Didn't find any major issues. You're on a roll. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Pull request was converted to draft
6820d60 to
b4b3cd6
Compare
Greptile SummaryThis PR adds a new design document for
Confidence Score: 4/5Safe to merge as documentation, but the two design gaps should be addressed before implementation begins. The document leaves two gaps in the permission model: the AllowCommands matching algorithm is undefined (enabling potential bypass via compound shell operators), and the agent loop has no specified branch for a denied tool call. Both are design-level gaps that would directly affect how implementers build the security boundary. docs/ag-harness/ag-harness-design.md — the Permissions and Agent Loop sections need clarification before implementation begins. Reviews (28): Last reviewed commit: "Define `ag-harness` design" | Re-trigger Greptile |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Dismissed because a newer commit was pushed; Greptile will re-review the current head.
Dismissed because a newer commit was pushed; Greptile will re-review the current head.
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. ℹ️ You can also turn on project coverage checks and project coverage reporting on Pull Request comment Thanks for integrating Codecov - We've got you covered ☂️ |
Dismissed because a newer commit was pushed; Greptile will re-review the current head.
Dismissed because a newer commit was pushed; Greptile will re-review the current head.
Dismissed because a newer commit was pushed; Greptile will re-review the current head.
Dismissed because a newer commit was pushed; Greptile will re-review the current head.
Dismissed because a newer commit was pushed; Greptile will re-review the current head.
- Document the planned `ag-harness` as a light, Rust-native LLM harness between an app and a model, with agentty as its first consumer. - Define the core features: `read`, `write`, `edit`, and `bash` tools, git-style diff edits, a permission policy on every tool call, append-only JSONL session journals, cache-aware context, and a typed event stream. - State the non-goals: no orchestration, no sandboxing in core, and no UI. - Describe the crate layout, the one-process model with sessions as state and turns as async tasks, the agent loop, the provider layer, and the library API. - Add mermaid diagrams, a roadmap, and a decision log.
- Defines `ag-harness` as a lightweight Rust-native harness layer between applications and model providers. - Documents core `read`, `write`, and `bash` tools, structured patch edits, permission policy, persisted sessions, context handling, output caps, and model tiers. - Sketches the crate layout, runtime process model, multisession workflow, agent loop, library API roles, service wrapper roadmap, and comparisons with existing harnesses.
|
2 participants
ag-harnessas a lightweight Rust-native harness layer between applications and model providers.read,write, andbashtools, structured patch edits, permission policy, persisted sessions, context handling, output caps, and model tiers.