Skip to content

chore: bump sp1 to 6.2.0#350

Open
Freyskeyd wants to merge 6 commits into
mainfrom
bump-sp1-6.2.0
Open

chore: bump sp1 to 6.2.0#350
Freyskeyd wants to merge 6 commits into
mainfrom
bump-sp1-6.2.0

Conversation

@Freyskeyd
Copy link
Copy Markdown
Member

@Freyskeyd Freyskeyd commented May 16, 2026

This upgrades the prover workspace to SP1 6.2.0 on top of op-succinct 3.9.0.

Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.

  • Bumps direct SP1 and P3 pins for the workspace and proof program.
  • Updates sp1-contract-call to its SP1 6.2.0-compatible revision.
  • Replaces the stale agglayer-elf-build dependency with local build-script logic
    because the published interop revision still pins sp1-build =6.1.0.

@Freyskeyd Freyskeyd requested a review from a team as a code owner May 16, 2026 00:35
@Freyskeyd Freyskeyd requested review from Ekleog-Polygon and hadjiszs and removed request for a team May 16, 2026 00:35
Copy link
Copy Markdown

@claude claude Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.

Tip: disable this comment in your organization's Code Review settings.

Signed-off-by: Simon Paitrault <spaitrault@polygon.technology>
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 2d4e6151da

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

println!("cargo::rerun-if-env-changed={BUILD_ENV_VAR}");

let elf_path = match build_mode()? {
BuildMode::Cached => cached_elf_path()?,
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Update the cached ELF when bumping SP1

With the default Cached path, normal cargo build embeds crates/aggchain-proof-builder/elf/riscv64im-succinct-zkvm-elf, but this commit bumps the SP1/proof-program dependencies without changing that ELF (I checked git ls-tree for this commit and its parent; both point to blob 529d18c...). As a result, builds that do not set AGGLAYER_ELF_BUILD=update still ship the old precompiled program even though the source and host dependencies now say SP1 6.2.0, so proofs/verification can be produced against stale code until the cached ELF is regenerated and committed.

Useful? React with 👍 / 👎.

Signed-off-by: Simon Paitrault <spaitrault@polygon.technology>
@Freyskeyd Freyskeyd changed the base branch from bump-op-succinct-3.9.0 to main May 19, 2026 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants