Invalidate extraction index cache after writes ( Close #28 )#29
Open
kiannidev wants to merge 1 commit into
Open
Invalidate extraction index cache after writes ( Close #28 )#29kiannidev wants to merge 1 commit into
kiannidev wants to merge 1 commit into
Conversation
Call invalidateExtractionCache() from writeExtractionJson and atomicWriteJson so getExtraction reflects disk state immediately instead of serving stale data for up to 30s. Fixes aglover1221#28
This was referenced May 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #28 —
listExtractions(),getExtraction(), andgetProductDir()memoize for 30s butinvalidateExtractionCache()was never called after disk writes. Pages and APIs returned stale extraction data until TTL expired.Related Issue
Fixes #28
Change Type
What Changed
writeExtractionJson()now callsinvalidateExtractionCache()after every write (covers batch worker, sync extract,extract-oneCLI)atomicWriteJson()invalidates when writingextraction.json(covers spotfix accept path)tests/unit/extraction-cache.test.tswith behavioral tests provinggetExtraction()sees new data immediately after writesFiles Changed
lib/pipeline/extract.tsinvalidateExtractionCache()inwriteExtractionJson()lib/pipeline/extraction-paths.tsinvalidateExtractionCache()inatomicWriteJson()for extraction.jsontests/unit/extraction-cache.test.tsValidation
Test Plan
r770(warms cache)