feat: extract Slice 8 asset capability base#233
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Extract the smallest coherent Slice 8 prerequisite from the conflicting #208 branch so relay Slices A/B/C and the final #208 rebase can build on a landable main commit.
Binding design: /home/adam/.openclaw/reports/app-origin-asset-relay-design-2026-07-21.md
Parent threat model: /home/adam/.openclaw/reports/data-segregation-design-2026-07-17.md §2
This base adds:
none(bearer/DPoP-safe<img>on the pre-existing non-relay path); native is explicitlynative-header-or-cookieThe asset URL contains only a keyed binding identifier, never the auth session id or proof. Asset responses are no-store. The optional mobile WebView cookie is host-only, HttpOnly, SameSite=Lax, and path-scoped to /api/assets/relay.
Supersedes #229
#229 reached its per-PR review allowance (2 reviews/day) before landing. This is the same
wizzo/dseg-s8-prereq-basebranch, recreated fresh per the starvation recipe so the corrected diff gets a fresh review. Round-2 findings on #229 are all fixed class-wide in HEAD226cc90a8:none, native=header/cookie), not connection-level credentialing — web assets resolve 200 on the non-relay path.Originnow parses to null and follows the non-HTTPS cookie path (303 + non-Secure cookie), nonew URL()500.force-cacherestricted to local cached-file sources; credentialed RN preview sources usereload.Verification
vp check,vp run typecheckgreen/api/assets/200 with no cookie/header; native advertises, gets/api/assets/relay/, rejects missing proof, succeeds with header/cookie; old client receives AssetClientUpgradeRequiredError; opaque/malformed Origin → 303 + cookie without SecureExplicitly left for later slices
No project audience classification, pairing-grant ceiling, or listener-split behavior is changed.