Skip to content

fix(server): backfill delivered terminal claims (ADA-194)#235

Merged
adamfgr merged 4 commits into
mainfrom
wizzo/ada-194-terminal-claim-backfill
Jul 22, 2026
Merged

fix(server): backfill delivered terminal claims (ADA-194)#235
adamfgr merged 4 commits into
mainfrom
wizzo/ada-194-terminal-claim-backfill

Conversation

@wizzoapp

@wizzoapp wizzoapp Bot commented Jul 22, 2026

Copy link
Copy Markdown

Fixes ADA-194 migration gap after #230.

Summary

  • add idempotent migration 054 for local child lifecycles already terminal before migration 053
  • require canonical per-child delivery evidence (matching parent system wake or wait-delivery tombstone) before inserting a satisfied claim
  • bind terminal evidence and claimed event sequence to migration 053's durable cutoff so skip-level and crash-interrupted upgrades keep genuinely undelivered wakes recoverable
  • preserve existing claims and exclude remote children

Verification

  • regression seeds a pre-existing terminal child with no claim, runs the backfill, and observes exactly zero parent wakes across the initial boot plus 3 simulated restarts
  • migration coverage includes completed/failed/killed/archived, idempotency, stale/live/remote exclusions, post-053 cutoff exclusions, and undelivered exclusions
  • focused suite: 4/4 relevant tests passed; server typecheck and changed-file format/lint clean
  • factory pre-commit gate: static checks plus clean Codex autoreview
  • fresh SQLite backup from production (live DB untouched): integrity ok; 165 evidence-backed legacy claims inserted in 6.02s; root 8ebe24fb has 7/7 local children claimed; every named probe is claimed

@wizzoapp
wizzoapp Bot marked this pull request as ready for review July 22, 2026 10:14

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 34c6c03058

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

@wizzoapp
wizzoapp Bot marked this pull request as draft July 22, 2026 10:52
@wizzoapp
wizzoapp Bot marked this pull request as ready for review July 22, 2026 10:52

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 2fb8bd76fb

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

@wizzoapp
wizzoapp Bot marked this pull request as draft July 22, 2026 11:13
@wizzoapp
wizzoapp Bot marked this pull request as ready for review July 22, 2026 11:14

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 804d9fa487

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

@wizzoapp
wizzoapp Bot marked this pull request as draft July 22, 2026 11:44
@wizzoapp
wizzoapp Bot marked this pull request as ready for review July 22, 2026 11:44

@adamfgr adamfgr left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approved by wizzo-approve: all policy conditions verified against HEAD f18a792.

@adamfgr
adamfgr merged commit e90c613 into main Jul 22, 2026
13 checks passed
@adamfgr
adamfgr deleted the wizzo/ada-194-terminal-claim-backfill branch July 22, 2026 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant