Sync settle inbox and reconcile subthread sidebar by wizzoapp[bot] · Pull Request #238 · agriffiths-bots/t3code

wizzoapp · 2026-07-22T13:53:19Z

Design recommendation — independently settled subthreads, visually grouped

Adam deliberately withheld his preference, so this recommendation is based on workflow merits and is intentionally easy to redirect before approval.

A — settle a parent and all descendants as one unit: strongest visual cohesion, but a blocked/working child makes settlement non-atomic and bulk actions surprising.
B — settle subthreads independently, keep each root tree together, and show aggregate open descendants: preserves worker-level inbox semantics without orphaning children.
C — exempt subthreads and settle only top-level parents: smallest change, but completed workers permanently occupy the inbox and a settled parent can misrepresent live child work.

Recommendation implemented: B. Each row owns its settled state. A parent tree stays in the active inbox while any member is unsettled; settled members become slim rows in place; the parent reports its open-descendant count; only a fully settled tree moves as a group into the history tail. This lets completed workers clear independently while preserving parent context.

What this PR brings in

Syncs upstream's server-backed settle/inbox sidebar overhaul in its own first commit, followed by the fork reconciliation in the second commit.
Uses fork-safe migration 055 to add nullable settlement state. Existing rows remain intact and decode as unsettled; no historical thread is silently moved out of the inbox.
Enables sidebar v2 by default and disables automatic age-based settlement by default. Both settings controls remain available, including an explicit sidebar opt-out.
Makes light the default theme for the shared web/desktop renderer while preserving explicit saved light, dark, or system preferences.
Retains the fork's subthread tree expansion state, child indentation, active-route visibility, keyboard order, and whole-tree settled pagination.

Ephemeral UI proof

Captured against an ephemeral server using a SQLite .backup copy of the live state DB plus new synthetic parent/child fixtures. The live DB was never opened by the proof server.

Before settling	After settling

Verification

Factory gate: full workspace typecheck, formatting/lint, and clean Codex autoreview
Full web unit suite plus focused mobile, server settlement/orchestration, contracts/settings, and desktop settings suites
Focused typechecks: contracts, web, mobile, server, and desktop
Isolated migrated-state browser proof in light mode, including settle before/after

Landing policy

Do not auto-merge. This PR requires Adam's manual design approval in addition to the normal CI, Codex review, and wizzo-approve conditions.

…cle (pingdotgg#4026) Co-authored-by: Claude Fable 5 <noreply@anthropic.com> Co-authored-by: maria-rcks <maria@kuuro.net>

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 0c0a299539

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 736303b741

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a73d712e3f

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

wizzoapp · 2026-07-22T16:14:11Z

[from Codex]: Closing only to refresh the exhausted per-PR Codex review allowance after three completed reviews and a fourth eyes reaction stalled for 30 minutes. The same branch and combined diff will immediately continue in one fresh replacement PR; no scope is being split.

wizzoapp · 2026-07-22T16:14:36Z

[from Codex]: Superseded by #239 from the identical branch/head solely to obtain a fresh Codex review. Continue approval and CI tracking there.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a45e7b2ff8

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-07-22T16:22:47Z

+          thread !== undefined &&
+          thread.settledOverride !== "settled" &&
+          serverConfigs.get(thread.environmentId)?.environment.capabilities.threadSettlement ===
+            true


Exclude blocked rows from bulk settle

When a multi-selection includes a row that is still running or waiting on approval/input, this filter still counts it as settleable because it only checks the override and server capability. Choosing Settle then clears the selection and dispatches attemptSettle for rows that useThreadActions.settleThread immediately rejects via canSettle, producing failure toasts instead of applying the action to the valid subset; filter with the same settle preflight before building the bulk action.

Useful? React with 👍 / 👎.

chatgpt-codex-connector · 2026-07-22T16:22:47Z

+              { id: "rename", label: "Rename thread" },
+              { id: "mark-unread", label: "Mark unread" },
+              { id: "delete", label: "Delete", destructive: true, icon: "trash" },


Restore archive access in v2 rows

With sidebarV2Enabled now defaulting on, this v2 row menu no longer exposes the archiveThread action—the menu goes from Rename/Mark unread directly to Delete, and the v2 bulk menu likewise has no Archive item. Because archived threads are still filtered out of this sidebar and only manageable after they have already been archived, users in the default v2 UI have no way to move a thread into the Archive without disabling v2; carry over the archive action or provide an equivalent path.

Useful? React with 👍 / 👎.

chatgpt-codex-connector · 2026-07-22T16:22:47Z

+      {prStateReporterThreads.map((thread) => {
+        const projectCwd =
+          projectCwdByKey.get(`${thread.environmentId}:${thread.projectId}`) ?? null;
+        if (thread.branch === null || (thread.worktreePath ?? projectCwd) === null) return null;


Clear stale PR state when reporters unmount

When a hidden descendant previously reported a closed or merged PR and then loses its branch or usable cwd, this guard stops rendering the non-row reporter, but the web reporter only writes to changeRequestStateByKey and never clears its key on unmount. That stale closed/merged entry is still read by effectiveSettled, so a now-branchless collapsed thread can remain classified in the settled tail until it is expanded/rendered; clear the key on reporter unmount or report null before skipping.

Useful? React with 👍 / 👎.

t3dotgg and others added 2 commits July 22, 2026 14:26

Sidebar v2 beta: flat thread list with a server-backed settled lifecy…

47d383c

…cle (pingdotgg#4026) Co-authored-by: Claude Fable 5 <noreply@anthropic.com> Co-authored-by: maria-rcks <maria@kuuro.net>

feat(sidebar): reconcile settle inbox with subthreads

0c0a299

wizzoapp Bot marked this pull request as ready for review July 22, 2026 13:53

chatgpt-codex-connector Bot reviewed Jul 22, 2026

View reviewed changes

Comment thread apps/web/src/components/Sidebar.logic.ts

Comment thread apps/server/src/orchestration/decider.ts Outdated

Comment thread apps/web/src/components/SidebarV2.tsx Outdated

codex: address PR review feedback (#238)

736303b

wizzoapp Bot marked this pull request as draft July 22, 2026 14:16

wizzoapp Bot marked this pull request as ready for review July 22, 2026 14:16

chatgpt-codex-connector Bot reviewed Jul 22, 2026

View reviewed changes

codex: address second PR review (#238)

a73d712

wizzoapp Bot marked this pull request as draft July 22, 2026 15:05

wizzoapp Bot marked this pull request as ready for review July 22, 2026 15:05

chatgpt-codex-connector Bot reviewed Jul 22, 2026

View reviewed changes

Comment thread apps/web/src/components/settings/BetaSettingsPanel.tsx

Comment thread apps/mobile/src/features/home/HomeScreen.tsx

Comment thread apps/server/src/orchestration/decider.ts

wizzoapp Bot added 3 commits July 22, 2026 16:23

style(sidebar): keep light surface white

3f4f947

style(sidebar): match classic light surface

c142469

codex: address final PR review (#238)

a45e7b2

wizzoapp Bot marked this pull request as draft July 22, 2026 16:01

wizzoapp Bot marked this pull request as ready for review July 22, 2026 16:02

wizzoapp Bot closed this Jul 22, 2026

chatgpt-codex-connector Bot reviewed Jul 22, 2026

View reviewed changes

Uh oh!

Conversation

wizzoapp Bot commented Jul 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Design recommendation — independently settled subthreads, visually grouped

What this PR brings in

Ephemeral UI proof

Verification

Landing policy

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

wizzoapp Bot commented Jul 22, 2026

Uh oh!

wizzoapp Bot commented Jul 22, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Jul 22, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector Bot Jul 22, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector Bot Jul 22, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

wizzoapp Bot commented Jul 22, 2026 •

edited

Loading