Skip to content

Fix no-op N/TAN loss-rate clamps (min result discarded) #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mklarmann wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix no-op N/TAN loss-rate clamps (min result discarded) #7

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions SALCAfield/SALCAfield_field.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -858,7 +858,7 @@ def unpack_dc(dc):
# calculate loss rate through NH3, N2O (only direct) and NOx
loss_rate_N_frac = (e_fert_kg_NH3_N+e_direct_kgN2O_N+e_fert_kgNOx_N) / \
fert_kgN # [kg N/kg N]
min(1.0, loss_rate_N_frac) # cannot be >1
loss_rate_N_frac = min(1.0, loss_rate_N_frac) # cannot be >1
else:
loss_rate_N_frac = 0 # [kg N/kg N]

Expand All @@ -867,7 +867,7 @@ def unpack_dc(dc):
# calculate loss rate through NH3, N2O and NOx
loss_rate_TAN_frac = (e_fert_kg_NH3_N+e_direct_kgN2O_N+e_fert_kgNOx_N) / \
fert_kgTAN # [kg TAN/kg TAN]
min(1.0, loss_rate_TAN_frac) # cannot be >1
loss_rate_TAN_frac = min(1.0, loss_rate_TAN_frac) # cannot be >1
else:
loss_rate_TAN_frac = 0 # [kg TAN/kg TAN]

Expand Down