Preserve culture_de = "allg." when resolving leaf cultures#15
Open
MarcelMagro wants to merge 1 commit into
Open
Preserve culture_de = "allg." when resolving leaf cultures#15MarcelMagro wants to merge 1 commit into
MarcelMagro wants to merge 1 commit into
Conversation
…ds with culture_de = "allg." are expanded to the corresponding leaf_culture_de based on the application_area_de. Previously, the culture_de column was also overwritten with the resolved leaf_culture_de, replacing the original value "allg.". This is now changed. A temporary helper column now stores whether the original value of culture_de was "allg.". After resolving the leaf cultures, the original value "allg." is restored in the culture_de column for these records. see example 5.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using resolve_culture_allg = TRUE in resolve_cultures(), records with culture_de = "allg." are expanded to the corresponding leaf cultures based on application_area_de.
Previously, the value of culture_de was replaced by the resolved leaf culture. This has been changed. The original value "allg." is now kept by temporarily storing it and restoring it after the leaf cultures have been resolved.
See Example 5.