Refactor EngineSessionCache

[qligier]

For clarity/better maintainability.

[Copilot]

Pull request overview

Refactors how MatchboxEngineSupport caches MatchboxEngine instances by replacing the previous EngineSessionCache implementation with a new MatchboxEngineCache bean, aiming to make caching clearer and easier to maintain.

Changes:

• Replaced EngineSessionCache usage with a new MatchboxEngineCache (permanent + expiring transient engines).
• Updated engine cache keying/logging to use CliContext.sessionId() (currently derived from hashCode()).
• Wired the new cache into Spring config via a dedicated @Bean and removed the old cache class.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
matchbox-server/src/main/java/ch/ahdis/matchbox/util/MatchboxEngineSupport.java	Switches engine caching lookups/stores to MatchboxEngineCache and updates logging/session-id handling.
matchbox-server/src/main/java/ch/ahdis/matchbox/util/MatchboxEngineCache.java	Introduces new cache abstraction for permanent and 60-minute transient engines.
matchbox-server/src/main/java/ch/ahdis/matchbox/util/EngineSessionCache.java	Removes the legacy session cache implementation.
matchbox-server/src/main/java/ch/ahdis/matchbox/config/MatchboxJpaConfig.java	Registers MatchboxEngineCache as a Spring bean and injects it into MatchboxEngineSupport.
matchbox-server/src/main/java/ch/ahdis/matchbox/CliContext.java	Adds sessionId() helper used for cache keys and logging.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.