feat(chat): improve attachment label display#242
Merged
Conversation
Display clipboard-pasted temporary images as `[Image 1]`, `[Image 2]`, while preserving actual filenames for drag-and-drop and pasted-path attachments. Keep labels consistent after submission. Changes: - Add a shared attachment-label helper that identifies clipboard images by their location under `TEMP_IMAGES_DIRECTORY`. - Number only clipboard images in attachment order; mixed input should render like `[Image 1] [diagram.png] [Image 2]`. - Use the helper in both `ChatInput` and submitted user-message rendering. - Keep attachment paths, submission payloads, cleanup behavior, and session storage unchanged. - Preserve filename labels for all non-clipboard attachments.
Images dropped directly beside or within existing text now become attachment badges, while surrounding text and cursor position are preserved. The fix is to detect the newly inserted drag-and-drop substring by comparing the previous and next input values, then extract the image from that inserted segment. That would support dropping an image directly beside existing text without requiring a space.
Codecov Report✅ All modified and coverable lines are covered by tests.
🚀 New features to boost your workflow:
|
remarkablemark
added
bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the motivation for this pull request?
Improve how image attachments are labeled in the chat UI — both in the input prefix and in rendered messages.
plan.md
What is the current behavior?
[some-uuid.png]).What is the new behavior?
Image 1,Image 2, etc.; file-path attachments continue to show their basename (e.g.[diagram.png]).getAttachmentLabelshelper centralises this logic and is shared by bothChatInputandMessage.getInsertedTextcorrectly isolates only the pasted segment so that prefix/suffix text around the cursor is preserved when an image is pasted mid-input.Checklist: