Conversation
brianhenn
commented
Jan 8, 2026
| @pytest.mark.parametrize( | ||
| "config_registry_class", | ||
| [ | ||
| CorrectorSelector, |
Contributor
Author
There was a problem hiding this comment.
My thought is that these registries are tightly coupled to ace and therefore it's appropriate to test them here even if they actually reside in core.
| MISSING_SYMBOLS.clear() | ||
|
|
||
|
|
||
| WHITELISTED_SYMBOLS = [ # used only for testing, not in __all__ |
Contributor
Author
There was a problem hiding this comment.
Alternatively, could avoid permanently registering these classes and thus having to whitelist by using context managers in the test modules.
brianhenn
commented
Jan 27, 2026
| def test_registry_symbols_are_imported(config_registry_class): | ||
| registered_config_names = config_registry_class.get_available_types() | ||
| for registered_config_name in registered_config_names: | ||
| registered_config = config_registry_class.registry._types[ |
Contributor
Author
There was a problem hiding this comment.
Relying on private registry._types here; could make public since we already make their name strings public.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a test that ensures that registered config classes for
aceare imported into the namespace for docs purposes. Adds some missing symbols covered by the test.