Open
Conversation
STX and FT will now automatically go to OP_FUND based on period and logic defined in next commits. NFT stays the same for now.
Need to verify that transfers are not possible outside these funcitons with tests and the treasury is officially locked down on an available 30day drip to the operating fund.
Contributor
Author
|
So with other contracts we have a pattern of STX, sBTC, and DAO token. In the treasury we have STX, FT, and NFT in a more broad definition. If we track the claims per period for just FT, then we could only withdraw sBTC or DAO token once per period, no separation. I think if we focus on the treasury as being the secure place for the DAO token, STX, and sBTC then we can scope it better then just being a general treasury. The question becomes what if another FT or NFTs get added? Do we need to support that now or introduce something later? To sum it up in a different way, should we streamline it so that:
|
List support is nice but let's keep this as simple as possible. List can be in the proposal as lines of code instead of a literal list, and we're not expecting a long list of entries that would push the limits anytime soon.
We might end up needing a blank/empty test file like this for each depending on where it was used, updated to just v3 for now to clear clarinet check errors.
Also more specific on print statement contents and consistency to use in other contracts.
Also updates error codes in prep for new extension, groups action errors with action proposals.
Should help with a few checks we're doing in separate contracts.
Considering splitting this into three distinct contracts with a specific purpose.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the operating fund contract
This also modifies the treasury to interact solely with the operating fund, creating an extra layer of protection and allowing us to open up core proposals sooner than originally anticipated in #39
Left to do:
Notable Changes:
get-current-period,get-stx-claimandget-ft-claimget-contract-infowith constants and configupdate-stx-claim,update-ft-claimwith write-once logic