#134 - fix to breaking changes introduced in Obsidian 1.5.4 (they did an internal refactoring of File Explorer, the fix follows the refactoring accordingly)

[SebastianMC]

I'm the author of the obsidian-custom-sort plugin which was also affected by the breaking changes in File Explorer introduced in Obsidian 1.5.4

I did a reverse engineering of Obsidian code to track back the relevant changes and then applied the fixes onto my plugin.

The fixes are simple and isolated, in this pull request I'm showing how to apply them onto the alx-folder-note plugin (which I love and use every day).

[FynnFreyer]

This seems to take care of #130 as well (therefore making #133 superfluous).

Also, I'm using this in my vault and can confirm it works flawlessly. Thanks for the good work!

[pho3nixf1re]

Please 2 merge 🐱

[SebastianMC]

Hi @pho3nixf1re

I'm unclear on the processes and rules around PR's and merging them in this github project.
While I've created this pull request, at the same time I don't have the write access required to do a merge.
Who can do the actual merge (or additional review, if the process requires that)?

[huyz]

@SebastianMC I'm using your fork directly until this is merged in. Thanks

[SebastianMC]

FYI
I'm the author of this pull request.
Unfortunately, this plugin (alx-folder-note) stopped working for me with Obsidian 1.7.1: the folder notes are no longer hidden in their parent folders (mode: 'same name as parent folder'). Reinstalling didn't help, playing with settings, etc. - no effect. I've been using this plugin from the very beginning with Obsidian. It seems to be abandoned now, based on the timestamps of recent commits and the long queue of unresolved issues.
In result I switched to a different folder notes plugin (Folder notes by Lost Paul), actively maintained, with equivalent functionality.
As a side effect, I will no longer maintain the code in this pull request.

[desvaters]

@SebastianMC May you tell us the name of the other folder notes plugin? ^^

[huyz]

@SebastianMC Thanks for letting us know.

Yes, please plug the alternate folder notes plugin please

[SebastianMC]

Hi @desvaters, @huyz,

updated my previous comment with an inline link.

The plugin is Folder notes by Lost Paul
It is actively maintained. It has a long list of open issues, but if you take a closer look it turns out that the author doesn't close them for some reason, even if answered, clarified or fixed.