Open
Conversation
- Add check_acp_agent() using shutil.which to verify agent CLI on PATH - Skip HTTP checks (llm_connectivity, api_key_valid, model_chain) for ACP provider - ACP configs get 7 checks instead of 9; non-ACP behavior unchanged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
researchclaw doctoralways runs three HTTP-based checks (llm_connectivity, api_key_valid, model_chain) regardless of provider. ACP users see confusing failures for checks that do not apply — ACP uses a local agent, not an HTTP API.Solution
check_acp_agent()— usesshutil.which()to verify the agent CLI is on PATH"acp", run the agent check instead of the 3 HTTP checksTest plan
check_acp_agentpasses when agent found, fails when missing