Fix _transport_sockname request initialization warning#13040
Open
nightcityblade wants to merge 1 commit into
Open
Fix _transport_sockname request initialization warning#13040nightcityblade wants to merge 1 commit into
nightcityblade wants to merge 1 commit into
Conversation
psf-chronographer
Bot
added
the
bot:chronographer:provided
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 3.14 #13040 +/- ##
=======================================
Coverage 98.24% 98.24%
=======================================
Files 135 135
Lines 48774 48786 +12
Branches 2613 2613
=======================================
+ Hits 47916 47929 +13
Misses 678 678
+ Partials 180 179 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. |
Merging this PR will not alter performance
Comparing 
Footnotes
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Adds
_transport_socknametoBaseRequest.ATTRSso request initialization can assign it without triggering the custom attribute deprecation warning, and adds a regression test.Are there changes in behavior for the user?
Users no longer get the deprecation warning when
BaseRequestcaptures the transport socket name during initialization.Is it a substantial burden for the maintainers to support this?
No. The change keeps the existing private attribute assignment behavior aligned with the class's allowed attribute set.
Related issue number
Fixes #13029
Checklist
CONTRIBUTORS.txtCHANGES/folder