Fix datetime last_modified rounding#13041
Open
nightcityblade wants to merge 1 commit into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 3.14 #13041 +/- ##
=======================================
Coverage 98.24% 98.24%
=======================================
Files 135 135
Lines 48774 48779 +5
Branches 2613 2613
=======================================
+ Hits 47916 47921 +5
Misses 678 678
Partials 180 180
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. |
Merging this PR will not alter performance
Comparing Footnotes
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Makes
StreamResponse.last_modifiedrounddatetimeinputs the same way the numeric timestamp path already does, and adds a regression test for the sub-second case.Are there changes in behavior for the user?
Yes. Datetime values with fractional seconds now round up consistently instead of truncating the fractional part.
Is it a substantial burden for the maintainers to support this?
No. This aligns two existing code paths that set the same header.
Related issue number
Fixes #5303
Checklist
CONTRIBUTORS.txtCHANGES/folder