ci: make the deploy job re-runnable after a partial failure#773
Merged
Conversation
Skip the Make Release step when the GitHub Release for the tag already exists, and pass skip-existing to the PyPI publish step. This lets the deploy job be re-run after a partial release failure (e.g. PyPI 5xx after the GitHub Release was already created) without having to cut a new version. The existence check matches only the literal "release not found" reply for the not-exists branch and re-raises anything else so auth, rate-limit, or transient network failures fail loudly with the real error instead of falling through to Make Release.
Member
Author
|
no point in waiting for the other jobs. only the release flow exercises this and we know its fine in yarl |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Make the
deployjob inci-cd.ymlre-runnable after a partialrelease failure.
Make Releasestep is now gated on a precedinggh release viewcheck, so it is skipped when the GitHub Release for the tagalready exists (instead of failing with
HTTP 422 already_exists).skip-existing: trueso aretry does not fail on dists that were already uploaded.
If PyPI returns a 5xx (or any other transient failure after the GitHub
Release was created), the maintainer can re-run the failed
deployjob instead of cutting a brand-new release. The existence check matches
only the literal
release not foundreply for the not-exists branchand re-raises anything else, so auth, rate-limit, or transient network
failures fail loudly with the real error instead of falling through to
Make Releaseand surfacing as a generic HTTP 422.This is a port of aio-libs/yarl#1721 to
frozenlist.Are there changes in behavior for the user?
No. This only affects how the release pipeline recovers from partial
failures; the produced artifacts and release are unchanged.
Related issue number
No tracking issue; mirrors aio-libs/yarl#1721.
Checklist
CONTRIBUTORS.txt— already listedCHANGES/folderAgent run details (optional, for reviewers)
Drafted with Claude Code (claude-opus-4-7); reviewed by @bdraco.
Local checks:
pre-commit run --files .github/workflows/ci-cd.yml CHANGES/773.contrib.rst— passed (yamllint, actionlint, changelog-filenames, GitHub Workflows validation).