Skip to content

fix(reset-pagination): Add user-facing same-slice error#1022

Draft
devin-ai-integration[bot] wants to merge 1 commit into
mainfrom
devin/1772639580-pagination-reset-message
Draft

fix(reset-pagination): Add user-facing same-slice error#1022
devin-ai-integration[bot] wants to merge 1 commit into
mainfrom
devin/1772639580-pagination-reset-message

Conversation

@devin-ai-integration
Copy link
Copy Markdown
Contributor

Summary

  • Adds a deterministic user-facing AirbyteTracedException.message for pagination reset same-slice failures.
  • Keeps the existing detailed internal_message and FailureType.system_error classification for debugging and retry behavior.
  • Updates pagination tracker unit coverage to assert message, internal message, and failure type.

Resolves https://github.com/airbytehq/airbyte-internal-issues/issues/16424
Related to https://github.com/airbytehq/oncall/issues/12584

Review & Testing Checklist for Human

  • Confirm Pagination reset cannot narrow the stream slice. is acceptable wording for this CDK guardrail and does not imply a user action.
  • Decide whether a separate connector behavior fix is needed for the deeper Google Ads change_status pagination-progress issue noted in https://github.com/airbytehq/oncall/issues/12584.
  • If this CDK change is released, verify a Google Ads prerelease can consume the updated CDK and surfaces the improved error text.

Notes

  • I believe this is not a breaking change because it only populates the user-facing trace message for an existing system_error; it does not change schemas, state, config, cursor fields, or FailureType.
  • No CDK version file was edited because this repository uses dynamic versioning and release notes are generated from GitHub releases.

Link to Devin session: https://app.devin.ai/sessions/b9e23ba8783445a38cf24162cbb9ca17

@devin-ai-integration
Copy link
Copy Markdown
Contributor Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

@github-actions
Copy link
Copy Markdown

👋 Greetings, Airbyte Team Member!

Here are some helpful tips and reminders for your convenience.

💡 Show Tips and Tricks

Testing This CDK Version

You can test this version of the CDK using the following:

# Run the CLI from this branch:
uvx 'git+https://github.com/airbytehq/airbyte-python-cdk.git@devin/1772639580-pagination-reset-message#egg=airbyte-python-cdk[dev]' --help

# Update a connector to use the CDK from this branch ref:
cd airbyte-integrations/connectors/source-example
poe use-cdk-branch devin/1772639580-pagination-reset-message

PR Slash Commands

Airbyte Maintainers can execute the following slash commands on your PR:

  • /autofix - Fixes most formatting and linting issues
  • /poetry-lock - Updates poetry.lock file
  • /test - Runs connector tests with the updated CDK
  • /prerelease - Triggers a prerelease publish with default arguments
  • /poe build - Regenerate git-committed build artifacts, such as the pydantic models which are generated from the manifest JSON schema in YAML.
  • /poe <command> - Runs any poe command in the CDK environment
📚 Show Repo Guidance

Helpful Resources

📝 Edit this welcome message.

@github-actions
Copy link
Copy Markdown

PyTest Results (Fast)

4 059 tests  ±0   4 048 ✅ ±0   7m 25s ⏱️ -20s
    1 suites ±0      11 💤 ±0 
    1 files   ±0       0 ❌ ±0 

Results for commit e212364. ± Comparison against base commit d3d1346.

@github-actions
Copy link
Copy Markdown

PyTest Results (Full)

4 062 tests  ±0   4 050 ✅ ±0   10m 58s ⏱️ +2s
    1 suites ±0      12 💤 ±0 
    1 files   ±0       0 ❌ ±0 

Results for commit e212364. ± Comparison against base commit d3d1346.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants