fix(http): Improve exhausted 5xx retry errors#1023
Draft
devin-ai-integration[bot] wants to merge 3 commits into
Draft
fix(http): Improve exhausted 5xx retry errors#1023devin-ai-integration[bot] wants to merge 3 commits into
devin-ai-integration[bot] wants to merge 3 commits into
Conversation
Co-Authored-By: bot_apk <apk@cognition.ai>
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
👋 Greetings, Airbyte Team Member!Here are some helpful tips and reminders for your convenience. 💡 Show Tips and TricksTesting This CDK VersionYou can test this version of the CDK using the following: # Run the CLI from this branch:
uvx 'git+https://github.com/airbytehq/airbyte-python-cdk.git@devin/1778625884-http-retry-error-message#egg=airbyte-python-cdk[dev]' --help
# Update a connector to use the CDK from this branch ref:
cd airbyte-integrations/connectors/source-example
poe use-cdk-branch devin/1778625884-http-retry-error-messagePR Slash CommandsAirbyte Maintainers can execute the following slash commands on your PR:
|
Co-Authored-By: bot_apk <apk@cognition.ai>
Co-Authored-By: bot_apk <apk@cognition.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Improve the user-facing error produced when HTTP server errors still fail after all retry attempts. Instead of surfacing the generic
Something went wrong in the connectorfallback through retry exhaustion, retry-exhausted HTTP 500/502/503/504 responses now emit deterministic API server status messages while preserving request URL, response code, and response text in the internal message.Resolves https://github.com/airbytehq/airbyte-internal-issues/issues/16430
Related to https://github.com/airbytehq/oncall/issues/10694
Review & Testing Checklist for Human
e.failure_typefor retry-exhausted server errors keeps the intended failure classification.Notes
source-salesloftis manifest-only/low-code, but the vague fallback is emitted by shared CDKHttpClientwhen a retryable HTTP exception exhausts retries, so the fix is at the CDK layer.transient_error.poetry run ruff format --check airbyte_cdk/sources/streams/http/http_client.py unit_tests/sources/streams/http/test_http_client.py,poetry run ruff check airbyte_cdk/sources/streams/http/http_client.py unit_tests/sources/streams/http/test_http_client.py, andpoetry run pytest unit_tests/sources/streams/http/test_http_client.py::test_send_with_retry_raises_specific_message_for_exhausted_server_error -q.Link to Devin session: https://app.devin.ai/sessions/482d9f86c837463ab9c1720d40640fff