fix: surface state cursor parse errors#1028
Draft
devin-ai-integration[bot] wants to merge 2 commits into
Draft
Conversation
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
👋 Greetings, Airbyte Team Member!Here are some helpful tips and reminders for your convenience. 💡 Show Tips and TricksTesting This CDK VersionYou can test this version of the CDK using the following: # Run the CLI from this branch:
uvx 'git+https://github.com/airbytehq/airbyte-python-cdk.git@devin/1778884375-state-cursor-error-message#egg=airbyte-python-cdk[dev]' --help
# Update a connector to use the CDK from this branch ref:
cd airbyte-integrations/connectors/source-example
poe use-cdk-branch devin/1778884375-state-cursor-error-messagePR Slash CommandsAirbyte Maintainers can execute the following slash commands on your PR:
|
Co-Authored-By: bot_apk <apk@cognition.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves https://github.com/airbytehq/airbyte-internal-issues/issues/16441
Related to https://github.com/airbytehq/oncall/issues/12314
AirbyteTracedExceptionwith a specific user-facing message.internal_messageinstead of relying on the generic connector fallback.This is a CDK-level error-message improvement for source state parsing. It does not change schemas, specs, state format, or retry classification, so I do not believe it is breaking.
Review & Testing Checklist for Human
ValueErrorduring concurrent cursor initialization does not hide unrelated initialization errors that should remain raw.Notes
Local checks run:
poetry run pytest unit_tests/sources/streams/concurrent/test_cursor.py::ConcurrentCursorStateTest::test_given_unparseable_state_cursor_when_initialize_then_raise_traced_exception -qpoetry run pytest unit_tests/sources/streams/concurrent/test_cursor.py unit_tests/sources/streams/concurrent/test_datetime_state_converter.py -qpoetry run pytest unit_tests/sources/declarative/test_state_delegating_stream.py::test_cursor_age_validation_raises_error_for_unparseable_cursor unit_tests/sources/streams/concurrent/test_cursor.py::ConcurrentCursorStateTest::test_given_unparseable_state_cursor_when_initialize_then_raise_traced_exception -qpoetry run ruff check airbyte_cdk/sources/streams/concurrent/cursor.py unit_tests/sources/streams/concurrent/test_cursor.py unit_tests/sources/declarative/test_state_delegating_stream.pypoetry run ruff format --check airbyte_cdk/sources/streams/concurrent/cursor.py unit_tests/sources/streams/concurrent/test_cursor.py unit_tests/sources/declarative/test_state_delegating_stream.pyLink to Devin session: https://app.devin.ai/sessions/6a6a8f8ec35248a3960a64b657a0899c