Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughAdds configurable auth type support for custom text-to-SQL providers (UI input, settings resolver, and request header construction), changes custom provider request payload to use Changes
Sequence Diagram(s)sequenceDiagram
participant UI as UI (Settings / Prompt)
participant App as scl-app.js
participant Provider as Custom Provider (HTTP)
participant DB as sqlite-worker
UI->>App: user sets custom-auth-type & triggers SQL generation
App->>App: resolveCustomTextToSqlAuthType(settings)
App->>Provider: POST with headers (based on authType) and messages (system, user, finalPrompt)
Provider-->>App: SQL response
App->>DB: (optional) use sqlite-worker for local processing
App-->>UI: display generated SQL
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem
🚥 Pre-merge checks | ✅ 1 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
src/common/js/scl-app.js (1)
674-706:⚠️ Potential issue | 🟠 MajorHandle chat-completions responses in the custom-provider path.
This request now sends an OpenAI-style
messagespayload, but the downstream extractor still ignoreschoices[0].message.content. With an OpenAI-compatible custom endpoint, successful responses will be treated as empty SQL andgenerateSqlFromPrompt()will fail.🧩 Suggested follow-up in
extractGeneratedSql()function extractGeneratedSql(response) { if (!response) return ''; if (typeof response === 'string') return response.trim(); + const chatContent = response?.choices?.[0]?.message?.content; + if (typeof chatContent === 'string') return chatContent.trim(); if (typeof response.sql === 'string') return response.sql.trim(); if (typeof response.query === 'string') return response.query.trim(); if (response.data && typeof response.data.sql === 'string') return response.data.sql.trim(); return ''; }Also applies to: 740-748
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@src/common/js/scl-app.js`:
- Around line 570-575: The function resolveCustomTextToSqlAuthType treats any
non-exact "Bearer" as a header name; change it to normalize case-insensitively
so that values like "bearer" or "BEARER" are mapped to the canonical "Bearer"
string, otherwise return the original trimmed value as the header name; apply
the same case-insensitive normalization to the other similar helper near lines
678-682 that determines the header name for custom SQL auth.
- Around line 651-658: The system prompt object currently added to the message
contents (the object with role: 'system' and parts containing the SQL generator
text) must be removed from the contents array and instead set on the top-level
request field system_instruction; locate where the Gemini request is built (the
code that constructs the contents array including the role: 'system' object) and
replace that behavior by extracting the parts text (e.g., parts[].text or join
multiple parts) and assigning it to system_instruction, ensuring the contents
array only contains user/assistant messages and that the system prompt is not
duplicated.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: fbf6b6c3-74e1-498e-9e1b-8ede45659ab4
📒 Files selected for processing (3)
src/common/js/scl-app.jssrc/index.htmlsrc/public/js/sqlite-worker.js
ChatThere are 3 ways to chat with CodeRabbit:
CodeRabbit commands
Other keywords and placeholders
CodeRabbit configuration file (
|
|
Note Docstrings generation - SUCCESS |
coderabbitai bot
added a commit
that referenced
this pull request
Mar 11, 2026
Docstrings generation was requested by @airen1986. * #6 (comment) The following files were modified: * `src/common/js/scl-app.js`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
New Features
Chores