Skip to content

Feature/new event detector#88

Merged
viktorbeck98 merged 8 commits intodevelopmentfrom
feature/new-event-detector
Apr 14, 2026
Merged

Feature/new event detector#88
viktorbeck98 merged 8 commits intodevelopmentfrom
feature/new-event-detector

Conversation

@ernstleierzopf
Copy link
Copy Markdown
Contributor

Fixes #57

@ernstleierzopf ernstleierzopf changed the base branch from main to development March 16, 2026 11:25
Comment thread tests/test_detectors/test_new_event_detector.py Fixed
Comment thread tests/test_detectors/test_new_event_detector.py Fixed
Base automatically changed from development to main March 19, 2026 11:15
Comment thread tests/test_detectors/test_new_event_detector.py Fixed
@ernstleierzopf ernstleierzopf marked this pull request as ready for review April 10, 2026 10:48
@viktorbeck98 viktorbeck98 changed the base branch from main to development April 10, 2026 14:26
@viktorbeck98
Copy link
Copy Markdown
Collaborator

I changed the base branch from main to development, since the merge should be going to this branch.

Pls resolve the merge conflicts first. I'll review afterwards

@ernstleierzopf
Copy link
Copy Markdown
Contributor Author

I changed the base branch from main to development, since the merge should be going to this branch.

Pls resolve the merge conflicts first. I'll review afterwards

I changed the base branch from main to development, since the merge should be going to this branch.

Pls resolve the merge conflicts first. I'll review afterwards

Done.

Copy link
Copy Markdown
Collaborator

@viktorbeck98 viktorbeck98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!

I just made a small adjustment so that the auto-config doesn't print the events it has seen during the auto-configuration process to the config. This detector actually doesn't need an auto-config.

@viktorbeck98 viktorbeck98 merged commit 6338979 into development Apr 14, 2026
4 checks passed
@viktorbeck98 viktorbeck98 deleted the feature/new-event-detector branch April 14, 2026 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add NewEventDetector

2 participants