client: remove unused dependencies from build configuration#430
Open
dogukancagatay wants to merge 2 commits into
Open
client: remove unused dependencies from build configuration#430dogukancagatay wants to merge 2 commits into
dogukancagatay wants to merge 2 commits into
Conversation
f89c903 to
618d6d1
Compare
- Remove `PyMySQL` from Makefile fedora dependencies - Remove explicit `BuildRequires` from spec file (auto-generated by `%pyproject_buildrequires`) - Remove unused `click` from dev dependencies in `pyproject.toml`
618d6d1 to
cbed6a3
Compare
dogukancagatay
commented
Nov 3, 2025
| BuildRequires: python3dist(hatch-vcs) | ||
| BuildRequires: python3dist(flake8) | ||
| BuildRequires: python3dist(mypy) | ||
| BuildRequires: python3dist(pytest) |
Contributor
Author
There was a problem hiding this comment.
dev group dependencies could be included to be generated dynamically, but pytest is the only dev dependency used.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PyMySQLfrom Makefile fedora dependenciesBuildRequiresfrom spec file (auto-generated by%pyproject_buildrequires)clickfrom dev dependencies inpyproject.toml# About this change: What it does, why it mattersruffto fedora dependencies