Add Kafka topic creation scripts for inkless migration#155
Open
ezgong wants to merge 1 commit into
Open
Conversation
mparikhaiven
requested changes
Mar 4, 2026
| @@ -0,0 +1,18 @@ | |||
| Topic: AA_INPUT_PAYLOAD_VPN_IP_QUALITY_GEOLOCATION_TEST TopicId: ueQGsjXIQn2Iipi_vIjn_w PartitionCount: 8 ReplicationFactor: 2 Configs: flush.ms=60000,max.message.bytes=33554432,unclean.leader.election.enable=true,retention.bytes=107374182400 | |||
mparikhaiven
requested changes
Mar 4, 2026
Contributor
There was a problem hiding this comment.
rename the file to diskless instead of inkless
mparikhaiven
requested changes
Mar 4, 2026
| # This pulls just the numbers from the 'key=value' strings | ||
| MAX_MSG=$(echo "$line" | sed -n 's/.*max.message.bytes=\([0-9]*\).*/\1/p') | ||
| RETENTION=$(echo "$line" | sed -n 's/.*retention.bytes=\([0-9]*\).*/\1/p') | ||
|
|
Contributor
There was a problem hiding this comment.
there should be retention time parameter as well..
| # This pulls just the numbers from the 'key=value' strings | ||
| MAX_MSG=$(echo "$line" | sed -n 's/.*max.message.bytes=\([0-9]*\).*/\1/p') | ||
| RETENTION=$(echo "$line" | sed -n 's/.*retention.bytes=\([0-9]*\).*/\1/p') | ||
|
|
Contributor
There was a problem hiding this comment.
retention time is also necessary
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update this heading, and describe your changes
Added a script to create topics based on the output of the discovery script.