Claude Opus 4.8 (10 Teams, 3 Agents/Team) Review Report#4
Open
ZenithClown wants to merge 1 commit into
Open
Conversation
1. [VERY HIGH BUGFIX] Added the three logical-replication PUBLICATIONS that `tradesdb` subscribes
to but which this server did **not** previously expose: `stocksdb_securities_table`
(`securities_mw` + `securities_exchange_symbol_mw`), `stocksdb_exchange_table`
(`stock_exchange_mw`), `stocksdb_derivative_table` (`derivative_contract_mw`). Without these
the entire `tradesdb` subscription topology was inert. `wal_level = logical` required.
2. [HIGH BUGFIX] Renamed column `scock_exchange_acronym` → `stock_exchange_acronym` on
`common.stock_exchange_mw`. Logical replication maps columns **by name**, so this is renamed
in lock-step with the `tradesdb` subscriber (see *Migration Notes*).
3. [HIGH BUGFIX] Subscriber-side `wikidata_id` widened `varchar(8)` → `varchar(12)` on
`country_mw` / `state_mw` / `city_mw`, matching the corrected MacroDB publisher (state/city
Q-IDs already exceed 8 chars). `geoname_id` widened to `varchar(12)` for headroom.
4. [HIGH FEATURE] `corporate_actions_mw` extended with structured, machine-usable fields so the
downstream trading system can adjust historical OHLC: `ex_date`, `record_date`,
`ratio_old` / `ratio_new` (splits & bonus), `dividend_amount` + `dividend_currency_code`, and
a precomputed `price_adjustment_factor`.
5. [MEDIUM ENHANCEMENT] Each `private.*_tx` time-series fact promoted from a constraint-only grain
to an explicit composite **PRIMARY KEY** (Timescale-compatible, gives a replica identity if
ever published). `stock_exchange_mw` gains `ck_exchange_operational_dates`
(`operational_to ≥ operational_from`).
⚙️ Reference PR: aivenio/project.archon#2
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
ZenithClown
added
pr/blocked
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference PR: aivenio/project.archon#2