Add acceptsValue parameter to flag()#643
Open
gildor wants to merge 1 commit into
Open
Conversation
acceptsValue lets a boolean flag also accept an attached --flag=true|false value, parsed leniently like boolean() (an empty value errors). The value must be attached with =, so --flag value stays a positional. A value on a secondary (negation) name is an error pointing at the positive form, via the new Localization.valueOnFlagNegation.
gildor
force-pushed
the
flag-accepts-value
branch
from
June 10, 2026 07:01
f429617 to
6539696
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lets a boolean flag also accept an explicit attached value, parsed by the existing lenient
boolean()converter — handy when the value comes from a script or environment variable that already holds a boolean string:0..1. The value must be attached with=(acceptsUnattachedValue = false), so--cache valuestays unambiguous with a positional argument.boolean()already rejects it) — useful when the value comes from an envvar that may be misconfigured.--no-cache=true) is an error pointing at the positive form, via a newLocalization.valueOnFlagNegation.Companion to #642 (
negatable). The two are orthogonal and compose — with both,option("--cache").flag(negatable = true, acceptsValue = true)accepts--cache,--no-cache, and--cache=true|false. They touch the sameflag/nullableFlagfunctions, so whichever lands second needs a small rebase (happy to do it).Includes the regenerated ABI dump, changelog, docs, and tests (
FlagValueTest).