Upgrade https-proxy-agent to drop rewrite of https.request()#19
Open
zckrs wants to merge 1 commit intoakamai:masterfrom
Open
Upgrade https-proxy-agent to drop rewrite of https.request()#19zckrs wants to merge 1 commit intoakamai:masterfrom
https.request()#19zckrs wants to merge 1 commit intoakamai:masterfrom
Conversation
* https-proxy-agent v2.1.1 to v5.0.0 * http-proxy-agent removed (not used in code) You use a old and strange version of https-proxy-agent who rewrite the original function 'https.request()' ... https://github.com/TooTallNate/node-agent-base/blob/4.3.0/patch-core.js#L13 This rewrite are not neccesary and produce bug when we use a Url object. `Object.assign({}, _options);` will transform a Url into Symbol https://www.diffchecker.com/NGxe92j3
Author
|
ping @AstinCHOI |
Author
|
ping @kporowski |
Author
|
ping @vreddhi |
Author
|
@rajiv @benlancaster @alzix @akalcosmin Can someone review, merge and release this PR please ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You use a old and strange version of https-proxy-agent who rewrite the
original function 'https.request()' ...
https://github.com/TooTallNate/node-agent-base/blob/4.3.0/patch-core.js#L13
This rewrite are not neccesary and produce bug when we use a Url object.
Object.assign({}, _options);will transform a Url into Symbolhttps://www.diffchecker.com/NGxe92j3