Open
Conversation
-Remove armouring.md under specializations -Replace with specializations/armouring/start_here.md
-Began work on page -Add terminology and intro sections
-Added a book
greenbagels
suggested changes
Jul 10, 2024
Contributor
greenbagels
left a comment
greenbagels
left a comment
There was a problem hiding this comment.
A couple comments:
- Way too many commits. If you're up for it @AmityU54, you can learn how to rebase commits (specifically, how to squash them); or, @akatch can configure squash commits for pull requests if he hasn't already.
- I'm generally not a fan of including images in the repository. At least, not as many / as large of images as you've included in the tutorial and static images folders. Every time a file (such as an image) is edited, git tracks an additional copy of that file, and even after compression, small changes in binary files like images might not lead to small changes in compressed size! Combine this with the rather large size of images (most of them are around 300kB+) and this repository gets very large very quickly.
- Not all the tutorial images uploaded are used in the tutorial; is it finished? I don't think it's worth merging a pull request until the feature we're considering is completed (or at least, is a complete initial draft).
Comment on lines
+24
to
+29
| * [Techniques of Medieval Armour Reproduction: The 14th Century | Brian Price](https://www.dropbox.com/s/p7x4jre1twcdyc5/Techniques%20of%20Medieval%20Armour%20Reproduction%20The%2014th%20Century%20by%20Brian%20R.%20Price%20(z-lib.org).pdf?dl=0) | ||
| * [Tips, Techniques, Tools, Sources and Resources: For the Armourer | Douglas W. Strong, Historical Research Press](https://www.dropbox.com/scl/fi/hspwr5ey4s8kqbiu0vr7j/armourer.pdf?rlkey=ht551gbrek66gwpkg0qirp2i9&dl=0) | ||
| * [Basing Armouring: A Practical Introduction to Armour Making, Second Edition | Paul Blackwell](https://www.dropbox.com/scl/fi/eq83lzpuo8j0rtl8x54e0/Basic-Armouring.pdf?rlkey=3gf8qvjrk5xnu2i890e8tqy5b&dl=0) | ||
| * [The Complete Great Bascinet: Techniques of Construction | Douglas W. Strong, Historical Research Press](https://www.dropbox.com/scl/fi/bdvnf0xdg3p9kgdqkmj3t/Complete_Great_Bascinet.pdf?rlkey=2ybg4bsqvyb2oqsl1akphr6ue&dl=0) | ||
| * [The Complete d’Aubernon Armour: Techniques of Construction (Volumes XVII-XIX) | Douglas W. Strong, Historical Research Press](https://www.dropbox.com/scl/fi/jykv17m5yj9ilop9flj7c/dauberoncompletearmour.pdf?rlkey=spj6lxfp2q2brinuurvtiep0n&dl=0) | ||
| * [Some Notes on Great Helms, Crests and Early Tournament Reinforces | Dirk H. Breiding](https://www.dropbox.com/scl/fi/cuymf0nb5d0b0l5hcluzc/Some_Notes_on_Great_Helms_Crests_and_Ear.pdf?rlkey=uv04hm5a7k0tlr7wpv3rl5gmq&dl=0) |
Contributor
There was a problem hiding this comment.
If these books are copyrighted, we need to think carefully before linking to copies of them hosted on Dropbox.
| --- | ||
| # Equipping your shop | ||
| ## Basics | ||
| There are an overwhelming amount of tools at an armourer's disposal. A fully equipped armourer's shop has more tools than most other metalworking pursuits use. This is a significant factor in armouring being such a difficult craft to master. However, it isn't so overwhelming as it seems- most tools seen aren't really necessary, and many are just for quality of life or can be substituted/made.\ |
Contributor
There was a problem hiding this comment.
It does not seem super helpful (or even accurate) to try to compare the # of tools an armorer has to other kinds of metal smiths, imo.
making the book list legal
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.