fix(commands.lua): fix function close_others#882
Open
minhtri2710 wants to merge 1 commit intoakinsho:mainfrom
Open
fix(commands.lua): fix function close_others#882minhtri2710 wants to merge 1 commit intoakinsho:mainfrom
minhtri2710 wants to merge 1 commit intoakinsho:mainfrom
Conversation
akinsho
reviewed
Mar 28, 2024
| if i ~= index then | ||
| delete_element(id) | ||
| else | ||
| id = 2 |
Owner
There was a problem hiding this comment.
I don't understand what this line of code is trying to do
akinsho
reviewed
Mar 28, 2024
Owner
akinsho
left a comment
akinsho
left a comment
There was a problem hiding this comment.
@minhtri2710 thanks for the PR, can you explain in more detail exactly what you are trying to fix i.e. a step by step of when this issue occurs and why you chose a specific solution so it's clear what is happening
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I encountered an error because item.id in state.components is no longer suitable for tabclose to use. I changed the code to be able to close the tabs before and after the current tab. I use Windows OS.