Merged
Conversation
waiting-for-dev
force-pushed
the
waiting-for-dev/term_new
branch
from
6789998 to
e7cc284
Compare
Humans are bad at remembering numbers, so this command allows you to open a new terminal at the next available count. It's helpful in combination with `:TermSelect` to work with terminals without needing to remember numbers. It supports the regular arguments as `:ToggleTerm`.
waiting-for-dev
force-pushed
the
waiting-for-dev/term_new
branch
from
e7cc284 to
f57953a
Compare
akinsho
approved these changes
Feb 22, 2025
Owner
akinsho
left a comment
akinsho
left a comment
There was a problem hiding this comment.
Sorry for the long delay this seems reasonable to me, haven't looked at the code in a while so hopefully there isn't some assumption this breaks
Owner
|
Think the testing workflow need some maintenance, probably not the code breaking |
akinsho
reviewed
Feb 23, 2025
| end | ||
| end | ||
|
|
||
| M.__next_id = next_id |
Owner
There was a problem hiding this comment.
I actually think this isn't necessary anymore. Since I wasn't exporting next_id before this was a way of trying to do it privately so I could use it in tests but now it's public this line can be removed and the corresponding usages of M.__next_id can just be M.next_id
vandalt
pushed a commit
to vandalt/toggleterm.nvim
that referenced
this pull request
Apr 1, 2025
* feat: Add TermNew command Humans are bad at remembering numbers, so this command allows you to open a new terminal at the next available count. It's helpful in combination with `:TermSelect` to work with terminals without needing to remember numbers. It supports the regular arguments as `:ToggleTerm`. * Fix failing tests
|
Hello, @akinsho ! You think in create a new release/tag for this option? The last one is from December (as the last commit behind this) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Humans are bad at remembering numbers, so this command allows you to open a new terminal at the next available count. It's helpful in combination with
:TermSelectto work with terminals without needing to remember numbers. It supports the regular arguments as:ToggleTerm.