Fix clicking next/prev arrows when initialSlide is not 0#2029
Open
jorrit wants to merge 1 commit intoakiran:masterfrom
Open
Fix clicking next/prev arrows when initialSlide is not 0#2029jorrit wants to merge 1 commit intoakiran:masterfrom
jorrit wants to merge 1 commit intoakiran:masterfrom
Conversation
|
Please, merge this |
|
Hello all, what's the status of this PR, I'm needing this fixed. |
|
Is there any way we can get a timeline on when to expect this merged? |
|
Please, merge this +1 |
hila-achieved
approved these changes
Dec 22, 2021
|
Do you have any news? |
|
This repo has had very little movement in the last year. I see there are many open pull requests just waiting to be merged. Who has write access? If it's only @akiran, can we petition to get others to help maintain this project? |
Owner
|
This issue is already fixed |
|
If it’s already fixed, could you please point to the PR and release that addresses this issue? Ant design uses this library in their Carousel component. If there’s a specific version they should be at, then I’ll make a PR to pull in the correct version on their repo. |
|
come on, it's 2022 !! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #1946.
This bug got introduced with change 1c3d70c. When
initialSlideis set,targetSlidewas not set to the right value. This is fixed.Also, I think the intended change of 1c3d70c can be implemented slightly simpler, by just checking if the new value is out of the allowed bounds.