Check current viewport against responsive settings on initial load (fixes #2439)#2440
Open
John-Youngblood wants to merge 1 commit intoakiran:masterfrom
Open
Check current viewport against responsive settings on initial load (fixes #2439)#2440John-Youngblood wants to merge 1 commit intoakiran:masterfrom
John-Youngblood wants to merge 1 commit intoakiran:masterfrom
Conversation
Author
|
@akiran let me know if there is any other info on this PR and the related issue you would like me to provide. |
|
HI! I ran into the same issue and ended up implementing the same solution. Then I found your PR 😊 Thanks! |
|
@akiran Any update on this PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a manual check against the responsive query when the
Slidercomponent initially loads. This will make sure theSliderpulls in any related responsive settings based on the current viewport when it first renders. Theresponsive.spec.tsxtest for playwright was also updated to catch this edge case. It's initial viewport is now one that hits a responsive breakpoint instead of the default. This fixes issue #2439