Merged
Conversation
Collaborator
Author
|
Final cube looks a-OK on the edges, so ready for review! |
- Trim cube at start of postprocessing, rather than at the end - Add rebin option to trim_cube (True by default) - Add more robust checks for Stokes axis and various positional axes in trim_cube - Overwrite should now actually work as intended in trim_cube
thomaswilliamsastro
force-pushed
the
trim-postprocess-start
branch
from
901e49e to
d97b6e4
Compare
e-koch
reviewed
Feb 19, 2026
Collaborator
e-koch
left a comment
e-koch
left a comment
There was a problem hiding this comment.
The changes all look good to me.
One question just to clarify: the trim is always after the pbcorr step?
Collaborator
Author
|
It's the first part of the postprocessing, as the image and pb get copied over from imaging to postprocess. There's another trim later where it'll also downsample the axes, same as previously |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.