Do not write to CWD in tests#74
Closed
lamontj wants to merge 1 commit into
Closed
Conversation
|
For context, we've started using pogreb in the android build system, where source code is read-only during the build. |
The source tree may be read-only during the build. Use a temporary directory for tests that need to modify the file system.
db5e6b9 to
4bcfc97
Compare
Author
|
Test failures fixed |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #74 +/- ##
=======================================
Coverage 77.49% 77.49%
=======================================
Files 25 25
Lines 1804 1804
=======================================
Hits 1398 1398
Misses 281 281
Partials 125 125 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Owner
|
Yes, 59b5287 works in our read-only tree. Thanks for the patch! |
Owner
|
Thanks for confirming! I just merged my change to main, and I'm closing this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The source tree may be read-only during the build. Use a temporary directory for tests that need to modify the file system.