Use a non-mmap backend for Plan9#75
Merged
Conversation
Tested on 9FRONT.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #75 +/- ##
==========================================
- Coverage 77.32% 77.24% -0.09%
==========================================
Files 25 25
Lines 1804 1806 +2
==========================================
Hits 1395 1395
- Misses 283 285 +2
Partials 126 126 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Owner
|
Thank you for the contribution, exciting to see Pogreb working on Plan9! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This enables support for Plan9 by disabling the mmap backend on that platform. Plan9 uses 9P for all file-system interaction so mmap is impossible by design.
Tests pass on 9FRONT but sometimes fail due to a bug in
sync.RWMutex.The use case is eris-go which can serve a content-addressed file-system from a pogreb database, served via FUSE on Linux and 9P on Plan9.
Of all the Go databases in it's class, pogreb is the only one I've found that can actually work without mmap. And it's the fastest for my use case.