Skip to content

ci: pin React ESLint settings version#22

Open
akshitkrnagpal wants to merge 1 commit into
mainfrom
ci/fix-eslint-react-version
Open

ci: pin React ESLint settings version#22
akshitkrnagpal wants to merge 1 commit into
mainfrom
ci/fix-eslint-react-version

Conversation

@akshitkrnagpal

Copy link
Copy Markdown
Owner

Summary

  • Sets an explicit React version in the app ESLint flat config
  • Avoids eslint-plugin-react runtime version detection, which crashes under ESLint 10's rule context shape
  • Keeps the existing ESLint 9 config behavior while making the config compatible with PR Bump eslint from 9.39.4 to 10.4.0 #18's ESLint 10 bump

Test Plan

  • npx pnpm@10.33.0 --filter @edgepush/app lint
  • npx pnpm@10.33.0 lint
  • npx pnpm@10.33.0 typecheck

Related: #18

@akshitkrnagpal

Copy link
Copy Markdown
Owner Author

Review recommendation: approve.

No blocking findings.

Reviewed the single config change in apps/app/eslint.config.mjs. The added flat-config settings block is ordered after the Next config entries, and eslint --print-config confirms it overrides React settings to react.version: "19.2" while preserving the existing import resolver settings.

Checks run locally:

  • npx pnpm@10.33.0 install --frozen-lockfile
  • npx pnpm@10.33.0 --filter @edgepush/app lint
  • npx pnpm@10.33.0 lint
  • npx pnpm@10.33.0 typecheck

Also checked GitHub CI: ci is passing.

Note: GitHub would not allow this token to submit a formal approval because the PR is authored by the same account: Review Can not approve your own pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant