Ignore onSelect if selected tab is same and this tab#51
Open
i8wu wants to merge 1 commit intoaksonov:masterfrom
UCSD:master
Open
Ignore onSelect if selected tab is same and this tab#51i8wu wants to merge 1 commit intoaksonov:masterfrom UCSD:master
i8wu wants to merge 1 commit intoaksonov:masterfrom
UCSD:master
Conversation
Author
|
@aksonov Any chance this could get merged in please? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should fix an issue where the tab sometimes re-renders when pressing the current tab. I could change this to a boolean prop if for some reason people want the tab to re-render.