Open
Conversation
1. Fixed ambiguous Conversation type by using specific imports 2. Modified database repository to handle missing database gracefully 3. Fixed SQLx query_as macro usage to avoid compile-time checks
1. Fixed repository links to use relative paths 2. Added Contributing section 3. Added links to LICENSE file 4. Improved overall documentation structure
1. Added StreamErrorResponse struct to cherrycore types 2. Implemented WebSocket handling for stream reading 3. Fixed AclChecker struct naming to follow Rust conventions 4. Added proper error handling for WebSocket connections 5. Added configuration file for streamserver
- Increased test count from 4 to 70 tests across streamstore and cherrycore crates - Added comprehensive error handling tests for streamstore/errors.rs (3 tests) - Added extensive entry encoding/decoding tests for streamstore/entry.rs (8 tests) - Added thorough mem_table tests covering CRUD operations, concurrency, and validation (12 tests) - Added complete table tests for data management, CRC, and multi-buffer handling (15 tests) - Added JWT authentication tests for cherrycore/jwt.rs (11 tests) - Added type serialization and HTTP response tests for cherrycore/types.rs (17 tests) - Created test runner script (run_tests.sh) for easy test execution - Added comprehensive testing documentation (TESTING.md) - Fixed bugs discovered during testing (cap_remaining method in StreamData) - Enhanced error handling and validation logic - All tests passing with comprehensive coverage of core functionality Test categories include: - Happy path testing - Error condition testing - Edge case handling - Concurrency testing - Large data scenarios - Serialization/deserialization - Debug trait implementations
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.