-
Notifications
You must be signed in to change notification settings - Fork 14
fix: prod build update time error #111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
WalkthroughAdded a Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
🤖 Fix all issues with AI agents
In @.build/build.yaml:
- Around line 98-99: Replace the blind "git fetch --unshallow || true" with a
conditional that first checks shallow status (e.g., using "git rev-parse
--is-shallow-repository") and only attempts "git fetch --unshallow" when needed;
capture the fetch exit code and emit a warning log if the fetch fails so the
pipeline logs clearly indicate the last-modified-time fix may not apply.
Specifically, locate the step containing the literal "git fetch --unshallow ||
true" and change it to: detect shallow repo, run "git fetch --unshallow" if
shallow, and on non-zero exit emit a warning message clarifying the fetch failed
and that file last-modified timestamps may be inaccurate.
- Around line 83-90: The extraction of host and path from git remote URLs fails
for scp-style remotes (e.g., git@github.com:org/repo.git); update the logic that
sets host and path (the host=... and path=... assignments used before invoking
/katanomi/bin/ktn-task copy git) to detect whether the remote URL contains "://"
and use the existing sed rules for HTTP/HTTPS, otherwise handle scp-style by
stripping the optional user@ prefix, replacing the ':' separator with '/',
removing any ".git" suffix and any "@..." ref suffix, and then set host to the
hostname portion and path to the repo path (so ktn-task copy git
--server=${host} --scope-prefix=${path} receives correct values).
ee407a6 to
b128db9
Compare
Summary by CodeRabbit
Chores
New Features
✏️ Tip: You can customize this high-level summary in your review settings.