[WIP] Initial Implementation#1
Draft
alaust-dev wants to merge 12 commits intodevelopfrom
Draft
Conversation
alaust-dev
force-pushed
the
feature/implementation
branch
from
5b9397b to
eacbed9
Compare
jonas-be
suggested changes
May 22, 2024
jonas-be
left a comment
jonas-be
left a comment
There was a problem hiding this comment.
I have two general points to mention:
- I think it would be a good idea to have the option to unregister all the event handlers (I made a comment on one).
- The use of
!!is considered bad practice.
The rest looks good to me.
Note: I haven't reviewed the documentation part.
alaust-dev
force-pushed
the
feature/implementation
branch
from
ab42c03 to
80ad909
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.