Open
Conversation
5b10ac9 to
cbe61d8
Compare
This was referenced Mar 31, 2020
b2c5095 to
4e63025
Compare
4e63025 to
0901e94
Compare
…o improve-tests-setup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR includes #23 (as it touched
composer.jsonanyway), and :TestCaseclass with namespace did not existed back in this version)syntaxCheck)Data::buildFromUrl()(to prevent network errors in tests)sami/samito ^4.1 (needed to usesymfony/processthat runs the local web server). I had to remove thetheme => enhancedline insami_configuration.phpto run./buildAPI.sh. However, I did not committed the changes done in the docs in this PR, as it's outside the scope of my knowledge whether the changes would be good or not.You can see the build (including #23 and #24) passing here : https://github.com/gnutix/PHP-dataURI/pull/2/checks