Avoid casing math equations in Typst#56
Merged
Merged
Conversation
alerque
added
bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #55
This seems to have the desired effect and seems to work by limiting the matches from decending into math contexts at all. I did not expect this to be so hard to achieve and would have expected some sort of where clause or selector to work in conjuction with the regex matcher to exclude math contexts. Also I would have expected a simpler
show text:rules to work, but that has other recursion problems.It would be really nice if somebody more familiar with Typst scripting could look this over and either afirm this is a sane approach or suggest something better.